[Owasp-esapi-c++] Makefile Patch

[Jeffrey Walton]

Hi All,

I committed the attached patch. The patch was tested on Ubuntu and
fedora with GCC and ICC.

The patch moved warnings to `-Wall -Wextra`. The attached are the
warnings produced by GCC and ICC.

While I will advertise I would like to check-in, I won't be providing
this sort of play-by-play unless the project desires it.

Jeff
-------------- next part --------------

jeffrey at studio:~/Desktop/owasp-esapi-c++$ make
g++ -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -fsigned-char -fmessage-length=0 -Wall -Wextra -Wno-type-limits -Wno-unused -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/reference/DefaultEncoder.cpp -o src/reference/DefaultEncoder.o
g++ -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -fsigned-char -fmessage-length=0 -Wall -Wextra -Wno-type-limits -Wno-unused -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/errors/ValidationException.cpp -o src/errors/ValidationException.o
g++ -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -fsigned-char -fmessage-length=0 -Wall -Wextra -Wno-type-limits -Wno-unused -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/reference/DefaultValidator.cpp -o src/reference/DefaultValidator.o
g++ -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -fsigned-char -fmessage-length=0 -Wall -Wextra -Wno-type-limits -Wno-unused -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/EncoderConstants.cpp -o src/EncoderConstants.o
g++ -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -fsigned-char -fmessage-length=0 -Wall -Wextra -Wno-type-limits -Wno-unused -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/reference/validation/BaseValidationRule.cpp -o src/reference/validation/BaseValidationRule.o
g++ -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -fsigned-char -fmessage-length=0 -Wall -Wextra -Wno-type-limits -Wno-unused -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/errors/EnterpriseSecurityException.cpp -o src/errors/EnterpriseSecurityException.o
g++ -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -fsigned-char -fmessage-length=0 -Wall -Wextra -Wno-type-limits -Wno-unused -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/ValidationErrorList.cpp -o src/ValidationErrorList.o
g++ -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -fsigned-char -fmessage-length=0 -Wall -Wextra -Wno-type-limits -Wno-unused -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/codecs/Codec.cpp -o src/codecs/Codec.o
src/codecs/Codec.cpp: In static member function ?static std::string* esapi::Codec::hexArray()?:
src/codecs/Codec.cpp:24: warning: suggest parentheses around ?&&? within ?||?
src/codecs/Codec.cpp:24: warning: suggest parentheses around ?&&? within ?||?
src/codecs/Codec.cpp:25: warning: ?arrHex? may be used uninitialized in this function
g++ -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -fsigned-char -fmessage-length=0 -Wall -Wextra -Wno-type-limits -Wno-unused -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/codecs/PushbackString.cpp -o src/codecs/PushbackString.o
g++ -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -fsigned-char -fmessage-length=0 -Wall -Wextra -Wno-type-limits -Wno-unused -shared -o esapi-c++.so src/reference/DefaultEncoder.o src/errors/ValidationException.o src/reference/DefaultValidator.o src/EncoderConstants.o src/reference/validation/BaseValidationRule.o src/errors/EnterpriseSecurityException.o src/ValidationErrorList.o src/codecs/Codec.o src/codecs/PushbackString.o -lcryptopp -L/usr/local/lib -L/usr/lib -Llib -L/boost_1_47_0/stage/lib
jeffrey at studio:~/Desktop/owasp-esapi-c++$ 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: makefile.diff
Type: text/x-patch
Size: 2090 bytes
Desc: not available
Url : https://lists.owasp.org/pipermail/owasp-esapi-c++/attachments/20110802/ee46bc40/attachment-0001.bin 
-------------- next part --------------
make
icpc -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -std=c++0x -Wall -wd1011 -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/reference/DefaultEncoder.cpp -o src/reference/DefaultEncoder.o
icpc -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -std=c++0x -Wall -wd1011 -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/errors/ValidationException.cpp -o src/errors/ValidationException.o
icpc -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -std=c++0x -Wall -wd1011 -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/reference/DefaultValidator.cpp -o src/reference/DefaultValidator.o
./esapi/reference/validation/BaseValidationRule.h(69): warning #1125: function "esapi::ValidationRule::setEncoder(esapi::Encoder &)" is hidden by "esapi::BaseValidationRule::setEncoder" -- virtual function override intended?
  		virtual void setEncoder(const Encoder &) =0;
  		             ^

./esapi/reference/validation/BaseValidationRule.h(94): warning #1125: function "esapi::ValidationRule::whitelist(const std::string &, std::set<char, std::less<char>, std::allocator<char>>)" is hidden by "esapi::BaseValidationRule::whitelist" -- virtual function override intended?
  		virtual std::string whitelist(const std::string &, const std::set<char> &);
  		                    ^

icpc -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -std=c++0x -Wall -wd1011 -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/EncoderConstants.cpp -o src/EncoderConstants.o
icpc -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -std=c++0x -Wall -wd1011 -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/reference/validation/BaseValidationRule.cpp -o src/reference/validation/BaseValidationRule.o
./esapi/reference/validation/BaseValidationRule.h(69): warning #1125: function "esapi::ValidationRule::setEncoder(esapi::Encoder &)" is hidden by "esapi::BaseValidationRule::setEncoder" -- virtual function override intended?
  		virtual void setEncoder(const Encoder &) =0;
  		             ^

./esapi/reference/validation/BaseValidationRule.h(94): warning #1125: function "esapi::ValidationRule::whitelist(const std::string &, std::set<char, std::less<char>, std::allocator<char>>)" is hidden by "esapi::BaseValidationRule::whitelist" -- virtual function override intended?
  		virtual std::string whitelist(const std::string &, const std::set<char> &);
  		                    ^

icpc -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -std=c++0x -Wall -wd1011 -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/errors/EnterpriseSecurityException.cpp -o src/errors/EnterpriseSecurityException.o
icpc -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -std=c++0x -Wall -wd1011 -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/ValidationErrorList.cpp -o src/ValidationErrorList.o
icpc -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -std=c++0x -Wall -wd1011 -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/codecs/Codec.cpp -o src/codecs/Codec.o
icpc -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -std=c++0x -Wall -wd1011 -fpic -c -I. -I./esapi -I/usr/local/include -I/usr/include/c++/4.4 -I/boost_1_47_0 -I/Dev-Cpp/include src/codecs/PushbackString.cpp -o src/codecs/PushbackString.o
icpc -DNDEBUG=1 -g -O2 -DSAFEINT_DISALLOW_UNSIGNED_NEGATION=1 -pipe -std=c++0x -Wall -wd1011 -shared -o esapi-c++.so src/reference/DefaultEncoder.o src/errors/ValidationException.o src/reference/DefaultValidator.o src/EncoderConstants.o src/reference/validation/BaseValidationRule.o src/errors/EnterpriseSecurityException.o src/ValidationErrorList.o src/codecs/Codec.o src/codecs/PushbackString.o -lcryptopp -L/usr/local/lib -L/usr/lib -Llib -L/boost_1_47_0/stage/lib
jeffrey at studio:~/Desktop/owasp-esapi-c++$