[Esapi-php] EmailAddressValidationRule doubt/question

[jah]

On 15/11/2010 19:38, Matteo Pasotti wrote:
> Hi guys,
> first of all I want to thanks you all for your job.
> I'm writing to the list because I'm trying to use
> EmailAddressValidationRule class and I've a doubt.
>
> The class extends StringValidationRule but into the code I've found
>
> require_once dirname(__FILE__) . '/BaseValidationRule.php';
>
> This line prevents the class to load properly. so I've replaced it with
>
> require_once dirname(__FILE__) . '/StringValidationRule.php';
>
> I've done the right thing or not? I'm missing something else?

Hello Matteo and thank you for reporting this!

You are correct; validation rules that extend StringValidationRule ought to require_once StringValidationRule and not BaseValidationRule.  I've committed this change to this rule and three others in svn revision [ r823 ].

Thanks again for the report.

Kind regards,

jah

[ r823 ] http://code.google.com/p/owasp-esapi-php/source/detail?r=823