[Esapi-php] Updates for tonight - StringUtilities is done, RARM and IARM are finally fixed

[Andrew van der Stock]

Hi there,

Tonight is all about quality. I've resolved two long standing bugs and made another class "Finished". Yay!

r179 StringUtilities is now complete - fixed bugs. Tests are done. Moved test suite to the "Finished" section in AllTests (see r181)
r180 Removed dependancy on the broken Authenticator class in RandomAccessReferenceMap and IntegerAccessReferenceMap tests. 
r181 Updates to AllTests and SimpleTests. I've reflected the road map in these files. 

r180 is important as I believe as much as possible, tests should test only the class under test. Otherwise we end up with a tight coupling which is hard to work around. Previously as per the J2EE test suite, I needed Authenticator to work, and it's  obviously in a state of flux (== b0rked). Removing it made the test more about the ARM class under test, and less about Authenticator. Luckily, there was nothing wrong with update() - it worked fine after I removed calls to Authenticator and created four separate new tests, testing only one aspect of update() at a time. 

Finished
6/6 test cases complete: 322 passes, 0 fails and 0 exceptions.


Lastly, eregi() is deprecated under PHP 5.3.0 and that means, it's toast in PHP 6.0. Let's try to avoid those functions if we can. 

Exception: /Users/vanderaj/Documents/workspace/esapi-new/owasp-esapi-php/test/codecs/HTMLEntityCodecTest.php -> HTMLEntityCodecTest -> testDecode -> Unexpected PHP error [Function eregi() is deprecated] severity [E_DEPRECATED] in [/Users/vanderaj/Documents/workspace/esapi-new/owasp-esapi-php/src/codecs/HTMLEntityCodec.php line 278]

thanks,
Andrew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.owasp.org/pipermail/esapi-php/attachments/20091111/00e30b86/attachment.html